on the first request, avoid posting body#10
Draft
wizardishungry wants to merge 2 commits into
Draft
Conversation
|
Hi @wizardishungry sorry this flew under the radar for us. if you can get this to a working state I'm happy to run our batch of tests for the CLI to make sure it still works as expected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended more as a point of discussion than a claim that this approach is truly the correct behavior –
I have modified
RoundTripto avoid posting the body of requests on the first request. I came across the same problem in the upstream as described in #1. The RFC seems to imply that posting the entire body on the initial request is not necessary when not using integrity protection.